Allowing ICMP types.

[oliparcol]

Summary

The regexp used to convert ICMP string codes to integer was updated in the v7 refactor and the new one doesn't allow anymore passing strings of the type <icmp type>/<icmp code> (e.g. 3/4). This is used to generate rules of the type:

 pkts bytes target     prot opt in     out     source               destination         
    0     0 ACCEPT     1    --  *      *       0.0.0.0/0            0.0.0.0/0            state NEW icmptype 3 code 4 /* Allow ICMP fragmentation needed */

The function icmp_name_to_number returns nil when a string of the type <icmp type>/<icmp code> is used in the icmp property.

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified. (For example puppet apply)

[CLAassistant]

All committers have signed the CLA.