Port ranges as string with hyphen as range indicator should work

[2fa]

Summary

If you set dport|sport values as a string with - as range indicator puppet will be applying manifest on every run.

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified. (For example puppet apply)

[shubhamshinde360]

When dport/sport is passed as a string "561-570" the insync? method always returns nil since we only process the ports in case they are arrays otherwise return nil (falsey).
This results in the puppet applying the change even when the desired port ranges are the same as actual port ranges.

With this change the string port ranges are handled properly and the insync? method returns true when the port ranges are equal.

[shubhamshinde360]

Thanks @2fa,

Looks good to me.
Could you please rebase your branch with main before this is merged.

[2fa]

@shubhamshinde360 sorry, i was quite busy yesterday and just got your message. Do i need to rebase the branch or all is good now?

[shubhamshinde360]

Hey @2fa,
No worries. I rebased it. But it seems there is a rubocop failure in the PR checks. Could you please add a commit to this PR to address that. Other changes look good.

[2fa]

@shubhamshinde360 fixed the issue with rubocop but there are failed acceptance tests. I don't think that's on my side though.

[shubhamshinde360]

Merging this since the check failures are unrelated and need to be addressed separately.

Thanks @2fa for you contribution!