Skip to content

Allow a singular numeric port for the --to-ports parameter #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Allow a singular numeric port for the --to-ports parameter #1199

merged 1 commit into from
Nov 25, 2024

Conversation

gcoxmoz
Copy link
Contributor

@gcoxmoz gcoxmoz commented Mar 19, 2024

Summary

Allows a numeric port for --to-ports / firewall.toports

Additional Context

Variant[Integer[0, 65535] is Stdlib::Port, but using that fails with "firewall.toports references an unresolved type 'Stdlib::Port'" so oh well.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Resolves #1186

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@gcoxmoz gcoxmoz requested a review from a team as a code owner March 19, 2024 02:45
@praj1001 praj1001 merged commit 10b336c into puppetlabs:main Nov 25, 2024
49 of 50 checks passed
@gcoxmoz gcoxmoz deleted the numeric-toports branch November 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firewall.toports expects an undef value or a match for Pattern[/^\d+(?:-\d+)?$/], got Integer
3 participants