Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpossible to disable icc with 10.x version of this module #989

Open
bjvrielink opened this issue Aug 13, 2024 · 0 comments · May be fixed by #995
Open

Unpossible to disable icc with 10.x version of this module #989

bjvrielink opened this issue Aug 13, 2024 · 0 comments · May be fixed by #995
Labels
bug

Comments

@bjvrielink
Copy link

Describe the Bug

When the parameter docker::icc is set to false, this parameter is completely ignored

Expected Behavior

The OPTIONS variable in /etc/sysconfig/docker should include --icc=false

Steps to Reproduce

Steps to reproduce the behavior:

  1. docker::icc: false in hiera
  2. Upgrade to 10.x version of this module
  3. See the --icc=false parameter disapear in /etc/sysconfig/docker

Environment

  • Version 10.0.0
  • Platform Almalinux 9

Additional Context

The conversion from erb to epp replaced:
<% unless @icc == nil %> --icc=<%= @icc %><% end -%>
with:
<% if $icc { %> --icc=<%= $icc %><% } -%>
Which behaves completely different when icc is false. A workaround would be to set docker::icc to the string "false", but that will not work because manifests/init.pp demands it to be a boolean.
@bjvrielink bjvrielink added the bug label Aug 13, 2024
bjvrielink added a commit to bjvrielink/puppetlabs-docker that referenced this issue Sep 5, 2024
@bjvrielink
Allow --icc=false option for docker daemon
6d1a989 
This used to be possible in version 9.1.0 and older, but got lost in
translation from .erb to .epp templates.

Fixes puppetlabs#989
@bjvrielink bjvrielink linked a pull request Sep 5, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow --icc=false option for docker daemon bjvrielink/puppetlabs-docker
1 participant
@bjvrielink