Merged
Conversation
* Instead of having 4 options controlling purging we now have a single hash with four possible keys. * We purge everything by default. * `/etc/apt/preferences` is now always managed. * Add missing `mode` to some of the files.
Author
|
I have not yet had the time to look at the Beaker tests. I expect them to explode phenomenally. |
|
urgh, sorry, reviewing commit by commit made the inline comments look less readable in the PR :\ |
* Instead of having 4 options controlling purging we now have a single hash with four possible keys. * Include `apt::update` only _after_ we've assembled the `$_update` hash.
* Allow any configuration of apt to be done through data bindings by passing in hashes representing the resources. * Switch apt::ppa to use `distid` as set in `apt::params. This makes `apt::ppa` also work for LinuxMint.
Remove a lot of the redundant `key_` prefixes on `apt::key` and the `keyserver_` prefix on `apt_key`.
Turn `$key` into something that accepts a string or a hash of four keys representing the different options that can be passed on to `apt::key`.
daenney
force-pushed
the
daenney/hulk-smash-2
branch
from
55824e4 to
061bc49
Compare
The behaviour of passing down undef through multiple layers gets fuzzy so for now be explicit about the keyserver. Once Puppet 4 is out and this behaviour has been crystallised and tested we can revisit it.
daenney
force-pushed
the
daenney/hulk-smash-2
branch
from
00cf71d to
0cb48b0
Compare
Author
|
The last two commits ought to have come before my commit that does changes to |
underscorgan
pushed a commit
that referenced
this pull request
Mar 2, 2015
It's been a long time - how have you been
|
Looks good, thanks @daenney Also, I really like what github did apt::key: in your commit messages. |
LukasAud
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of commits changing a lot of behaviour of apt for the better. I can't do this as separate PR's as some of them depend on each other which would really slow down the process.
For review purposes I suggest having a look at each individual commit or brains might melt.