Skip to content

Add AllowOverrideList support #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2023
Merged

Add AllowOverrideList support #2486

merged 2 commits into from
Oct 27, 2023

Conversation

yakatz
Copy link
Contributor

@yakatz yakatz commented Oct 17, 2023 •
edited
Loading

Summary

AllowOverrideList allows more fine-grained control over which directives are allow in htaccess

Additional Context

There aren't any existing tests for AllowOverride and I am not sure where I would put new tests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@yakatz yakatz requested review from bastelfreak, ekohl, smortex and a team as code owners October 17, 2023 22:08
@Ramesh7 Ramesh7 merged commit 42eee24 into puppetlabs:main Oct 27, 2023
@yakatz yakatz deleted the feature/allowoverridelist branch December 18, 2023 22:02
@smortex smortex changed the title Add AllowOverrideList support Add AllowOverrideList support Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@Ramesh7 Ramesh7 Ramesh7 approved these changes

@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner

@smortex smortex Awaiting requested review from smortex smortex is a code owner

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yakatz @bastelfreak @Ramesh7 @ia-content