Skip to content

(CAT-1346) erb_to_epp conversion for mod directory #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

praj1001
Copy link
Contributor

@praj1001 praj1001 commented Sep 7, 2023

Summary

Conversion of ERB to EPP templates for puppetlabs-apache module. The files considered for conversion only limits to being present in the mod directory.

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@praj1001 praj1001 added the bugfix label Sep 7, 2023
@praj1001 praj1001 requested review from bastelfreak, ekohl, smortex and a team as code owners September 7, 2023 18:39
Ramesh7
Ramesh7 previously approved these changes Sep 18, 2023
@Ramesh7
Copy link
Contributor

Ramesh7 commented Sep 21, 2023

@praj1001 can you please rebase your PR?

@Ramesh7 Ramesh7 self-requested a review September 21, 2023 08:26
@praj1001 praj1001 force-pushed the CAT-1346_erb_to_epp_mod_directory branch 2 times, most recently from 1b5963a to b4ff6b5 Compare September 21, 2023 08:53
@praj1001 praj1001 force-pushed the CAT-1346_erb_to_epp_mod_directory branch from b4ff6b5 to ffbcb58 Compare September 21, 2023 09:58
Copy link

@dinesh-gujar dinesh-gujar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work

@Ramesh7 Ramesh7 merged commit dc16c12 into main Sep 21, 2023
@Ramesh7 Ramesh7 deleted the CAT-1346_erb_to_epp_mod_directory branch September 21, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants