CAT-1347 erb to epp conversion #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

praj1001 merged 1 commit into main from CAT-1347-erb-to-epp-conversion-vhost-files

Sep 29, 2023

dinesh-gujar commented Sep 7, 2023 •

edited

Loading

Summary

Converting ERB files to EPP for performance upgrade.

dinesh-gujar closed this

dinesh-gujar reopened this

dinesh-gujar self-assigned this

dinesh-gujar added the maintenance label

dinesh-gujar marked this pull request as ready for review

September 8, 2023 03:54

dinesh-gujar requested review from bastelfreak, ekohl, smortex and a team as code owners

September 8, 2023 03:54

ekohl reviewed

View reviewed changes

templates/vhost/_http2.epp Outdated Show resolved Hide resolved

ekohl reviewed

View reviewed changes

templates/vhost/_filters.epp Outdated Show resolved Hide resolved

smortex reviewed

View reviewed changes

templates/vhost/_aliases.epp Outdated Show resolved Hide resolved

templates/vhost/_http2.epp Outdated Show resolved Hide resolved

templates/vhost/_suexec.epp Outdated Show resolved Hide resolved

dinesh-gujar force-pushed the CAT-1347-erb-to-epp-conversion-vhost-files branch from 3c83e15 to 22eca98 Compare

September 21, 2023 06:06

Contributor

Ramesh7 commented Sep 21, 2023

can you please update your branch with main?

Author

dinesh-gujar commented Sep 21, 2023

can you please update your branch with main?

yes just waiting for review for my changes once approved will do that and will also do the rebase

dinesh-gujar closed this

dinesh-gujar reopened this

Ramesh7 reviewed

View reviewed changes

templates/vhost/_aliases.epp Outdated Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_aliases.epp Outdated Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_custom_fragment.epp Outdated Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_docroot.epp Outdated Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_docroot.epp Outdated Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_fallbackresource.epp Outdated Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_file_footer.epp Outdated Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_file_footer.epp Outdated Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_file_header.epp Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_filters.epp Outdated Show resolved Hide resolved

Ramesh7 reviewed

View reviewed changes

templates/vhost/_header.epp Outdated Show resolved Hide resolved

ekohl reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

ekohl requested changes

View reviewed changes

templates/vhost/_ssl.erb Outdated Show resolved Hide resolved

dinesh-gujar force-pushed the CAT-1347-erb-to-epp-conversion-vhost-files branch from 2b060c3 to 6dcf415 Compare

September 21, 2023 10:36

ekohl requested changes

View reviewed changes

Collaborator

ekohl left a comment

You use {-%> all the time, but (like @Ramesh7) I think it should be { -%>. I marked a few, but it's almost in every file.

templates/vhost/_charsets.epp Outdated Show resolved Hide resolved

templates/vhost/_filters.epp Outdated Show resolved Hide resolved

templates/vhost/_header.epp Outdated Show resolved Hide resolved

templates/vhost/_itk.epp Outdated Show resolved Hide resolved

templates/vhost/_wsgi.epp Outdated Show resolved Hide resolved

ekohl reviewed

View reviewed changes

Collaborator

ekohl left a comment

Minor notes. I'd also like to see data types in the EPP templates, but wouldn't block on that.

templates/vhost/_file_header.epp Outdated Show resolved Hide resolved

templates/vhost/_scriptalias.epp Outdated Show resolved Hide resolved

manifests/vhost.pp Outdated Show resolved Hide resolved

ekohl reviewed

View reviewed changes

manifests/vhost.pp Outdated Show resolved Hide resolved

ekohl reviewed

View reviewed changes

templates/vhost/_file_header.epp Outdated Show resolved Hide resolved

ekohl previously requested changes

View reviewed changes

manifests/vhost.pp Show resolved Hide resolved

manifests/vhost.pp Outdated Show resolved Hide resolved

manifests/vhost.pp Outdated Show resolved Hide resolved

dinesh-gujar force-pushed the CAT-1347-erb-to-epp-conversion-vhost-files branch 5 times, most recently from 3ee4bf7 to b259171 Compare

September 22, 2023 07:34

Author

dinesh-gujar commented Sep 22, 2023

@ekohl resolved the comments.

dinesh-gujar force-pushed the CAT-1347-erb-to-epp-conversion-vhost-files branch 3 times, most recently from 6352b60 to d95e93e Compare

September 22, 2023 10:14

Author

dinesh-gujar commented Sep 22, 2023

@ekohl please review

ekohl reviewed

View reviewed changes

templates/vhost/_scriptalias.epp Outdated Show resolved Hide resolved

dinesh-gujar force-pushed the CAT-1347-erb-to-epp-conversion-vhost-files branch 3 times, most recently from 55dd42f to 1935b2b Compare

September 28, 2023 06:39


          CAT-1347 erb to epp conversion

31a137b

dinesh-gujar force-pushed the CAT-1347-erb-to-epp-conversion-vhost-files branch from 1935b2b to 31a137b Compare

September 29, 2023 05:00

praj1001 approved these changes

View reviewed changes

Contributor

praj1001 commented Sep 29, 2023

LGTM

praj1001 approved these changes

View reviewed changes

Author

dinesh-gujar commented Sep 29, 2023

1 requested change is done but still showing up in git hub so dismissing review

dinesh-gujar dismissed ekohl’s stale review

September 29, 2023 10:34

addressed and resolved the request

praj1001 merged commit 9c73e67 into main

praj1001 deleted the CAT-1347-erb-to-epp-conversion-vhost-files branch

September 29, 2023 10:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

smortex smortex left review comments

ekohl ekohl left review comments

Ramesh7 Ramesh7 left review comments

praj1001 praj1001 approved these changes

bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Labels