Add MellonSetEnv support

[ghost]

Add MellonSetEnv support, will prepend MELLON_ to the environment variable name

Fixes #2416

[CLAassistant]

All committers have signed the CLA.

[ghost]

This is for issue #2416

[jordanbreen28]

@ic248 thanks for this submission!
Could you add a description to this PR?

[ghost]

Hi @jordanbreen28 ,

Sorry my first PR, think I've added that now.

Thanks
Ian

[ghost]

Anything else required from me to get this merged?

[bastelfreak]

@ic248 can you please rebase and add a unit test?

[ghost]

@bastelfreak I've rebased, not sure where to start for a unit test, as far as I can see none of the mod_auth_mellon directives currently have any form of tests. If you could push me in the right direction I could create something (not created unit tests before).

Thanks
Ian

[smortex]

I think you can add a new directory in spec/defines/vhost_spec.rb near line 303 with a somewhat complete mellon_* configuration (the test context is intended to set all parameters and check them all), and adjust near line 723 to add the corresponding checks.

We have some pointers to run unit tests here:
https://voxpupuli.org/docs/how_to_run_tests/

[ghost]

rebased again and added unit tests for mellon_*

[smortex]

Thanks! CI failure is just anoyance, I suggest adding a "magic comment" before line 631:

# rubocop:disable RSpec/ExampleLength

and the corresponding magic comment on line 750:

# rubocop:enable RSpec/ExampleLength

That should fix it!

[ghost]

Thanks @smortex I've added your suggestions, you've all been really helpful since I'm new to a lot of these CI and unit tests

[smortex]

LGTM!

[ghost]

Does anyone else need to review this before it can be merged in?

[smortex]

@ic248 I would like to see someone form Puppet approving this before merging, but if in a couple day nobody complained, I will assume nobody is bothered by this and that we can merge the PR 🤷.

[ghost]

Looks like things failed due to Puppet forge being down for maintenance

[ghost]

@malikparvez looks like Puppet forge is back online, should be good to rerun checks

[malikparvez]

@malikparvez looks like Puppet forge is back online, should be good to rerun checks

yes @ic248 it is up now and ci is successful...

[malikparvez]

thanks for your contribution @ic248