Flesh out Gemspec description #9321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, Puppet's Gemspec summary and description were identical short, single sentences. This commit updates Puppet's Gemspec description to a longer explanation of what Puppet does, taken from Puppet's README.
joshcooper
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Verified we no longer get a warning when building the gem
❯ gh pr checkout 9321
remote: Enumerating objects: 3, done.
remote: Counting objects: 100% (3/3), done.
remote: Total 3 (delta 2), reused 3 (delta 2), pack-reused 0
Unpacking objects: 100% (3/3), 620 bytes | 310.00 KiB/s, done.
From https://github.com/puppetlabs/puppet
* [new ref] refs/pull/9321/head -> PUP-12032/main/gemspec-summary
Switched to branch 'PUP-12032/main/gemspec-summary'
❯ bx gem build .gemspec
Successfully built RubyGem
Name: puppet
Version: 8.7.0
File: puppet-8.7.0.gem
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, Puppet's Gemspec summary and description were identical short, single sentences.
This commit updates Puppet's Gemspec description to a longer explanation of what Puppet does, taken from Puppet's README.