Support pip freeze URL format #9280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pip freeze` (https://pip.pypa.io/en/stable/cli/pip_freeze/) "outputs installed packages in requirements format" (https://pip.pypa.io/en/stable/reference/requirement-specifiers/). As of pip 19.1, pip also supports specifying a requirement as a URL, and, for packages that were installed using URL format, `pip freeze` will output package requirements in URL format. However, Puppet's `pip freeze` parser doesn't support URL format, so it doesn't realize that a package is installed if it uses URL format, causing every `puppet agent` run to attempt to reinstall the package. This PR adds support for parsing `pip freeze` URL format.
|
Can one of the admins verify this patch? |
joshcooper
added
triaged
cthorn42
approved these changes
Mar 18, 2024
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 7.x
git worktree add -d .worktree/backport-9280-to-7.x origin/7.x
cd .worktree/backport-9280-to-7.x
git checkout -b backport-9280-to-7.x
ancref=$(git merge-base d068941191ba289825b44343fec1a3d3f1173022 207a7dc7f271c9d97be400d0d2ebb80a5cda6cd2)
git cherry-pick -x $ancref..207a7dc7f271c9d97be400d0d2ebb80a5cda6cd2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip freeze(https://pip.pypa.io/en/stable/cli/pip_freeze/) "outputs installed packages in requirements format"(https://pip.pypa.io/en/stable/reference/requirement-specifiers/). As of pip 19.1, pip also supports specifying a requirement as a URL, and, for packages that were installed using URL format,
pip freezewill output package requirements in URL format.However, Puppet's
pip freezeparser doesn't support URL format, so it doesn't realize that a package is installed if it uses URL format, causing everypuppet agentrun to attempt to reinstall the package.This PR adds support for parsing
pip freezeURL format.Steps to reproduce