Skip to content

(PUP-11993) Style Cops - R #9270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

AriaXLi
Copy link
Contributor

@AriaXLi AriaXLi commented Feb 28, 2024

No description provided.

This commit enables the Style/RaiseArgs cop and fixes 253
autocorrectable offenses.
@AriaXLi AriaXLi requested a review from a team as a code owner February 28, 2024 18:11
This commit enables the Style/RedundantAssignment cop and fixes
64 autocorrectable offenses.
This commit enables the Style/RedundantBegin cop and fixes 815
autocorrectable offenses.
@AriaXLi AriaXLi requested review from a team as code owners February 28, 2024 21:19
This commit enables the Style/RedundantCondition cop and fixes 20
autocorrectable offenses.
@AriaXLi
Copy link
Contributor Author

AriaXLi commented Feb 28, 2024

Just 4 cops this time because there were a lot of changes needed for RedundantBegin

Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier to review using git review -w --word-diff=color 2bc53e66fa..

@joshcooper joshcooper merged commit d068941 into puppetlabs:main Mar 1, 2024
@joshcooper joshcooper added the maintenance Maintenance chores are excluded from changelogs label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants