Skip to content

Correct Red Hat service providers #9212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/puppet/provider/service/redhat.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

commands :chkconfig => "/sbin/chkconfig", :service => "/sbin/service"

defaultfor 'os.family' => :redhat
defaultfor 'os.name' => :amazon, 'os.release.major' => ["2017", "2018"]
defaultfor 'os.name' => :redhat, 'os.release.major' => (4..6).to_a
defaultfor 'os.family' => :suse, 'os.release.major' => ["10", "11"]

Expand Down
4 changes: 2 additions & 2 deletions lib/puppet/provider/service/systemd.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
confine :true => Puppet::FileSystem.exist?('/proc/1/comm') && Puppet::FileSystem.read('/proc/1/comm').include?('systemd')

defaultfor 'os.family' => [:archlinux]
defaultfor 'os.name' => :redhat
defaultfor 'os.family' => :redhat, 'os.release.major' => ["7", "8", "9"]
defaultfor 'os.family' => :redhat
notdefaultfor 'os.name' => :redhat, 'os.release.major' => (4..6).to_a # Use the "RedHat" service provider
defaultfor 'os.family' => :redhat, 'os.name' => :fedora
defaultfor 'os.family' => :suse
defaultfor 'os.family' => :coreos
defaultfor 'os.family' => :gentoo
notdefaultfor 'os.name' => :amazon, 'os.release.major' => ["2017", "2018"]
defaultfor 'os.name' => :amazon, 'os.release.major' => ["2", "2023"]
defaultfor 'os.name' => :debian
notdefaultfor 'os.name' => :debian, 'os.release.major' => ["5", "6", "7"] # These are using the "debian" method
Expand Down
1 change: 1 addition & 0 deletions spec/unit/provider/service/redhat_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

[4, 5, 6].each do |ver|
it "should be the default provider on rhel#{ver}" do
allow(Facter).to receive(:value).with('os.name').and_return(:redhat)
allow(Facter).to receive(:value).with('os.release.major').and_return(ver)
expect(provider_class.default?).to be_truthy
end
Expand Down