Skip to content

Revert "Merge pull request #8353 from GabrielNagy/PUP-10670/add-serve… #8374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2020
Merged

Revert "Merge pull request #8353 from GabrielNagy/PUP-10670/add-serve… #8374

merged 1 commit into from
Oct 9, 2020

Conversation

GabrielNagy
Copy link
Contributor

…rport-setting"

This reverts commit a2230bc, reversing
changes made to 894a8d4.

The default masterport value became a string (due to the interpolation
of $serverport), which breaks puppetserver unit tests.

Revert this change and open a new PR which also includes a port
setting type.

@GabrielNagy
Revert "Merge pull request puppetlabs#8353 from GabrielNagy/PUP-10670…
dfc365b 
…/add-serverport-setting"

This reverts commit a2230bc, reversing
changes made to 894a8d4.

The default `masterport` value became a string (due to the interpolation
of `$serverport`), which breaks puppetserver unit tests.

Revert this change and open a new PR which also includes a `port`
setting type.
@GabrielNagy GabrielNagy requested review from a team October 9, 2020 07:33
@gimmyxd gimmyxd merged commit 69c20eb into puppetlabs:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gimmyxd gimmyxd gimmyxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabrielNagy @gimmyxd