(PUP-10604) Guard against JRuby FIPS #8319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppetserver still loads all types and providers during catalog compilation,
and JRuby with FIPS enabled cannot require rubygems. So guard the require
statement like we do in puppet/ssl/openssl_loader.
The `/opt/puppetlabs/bin/puppetserver gem install` command will fail
when running with JRuby with FIPS, so confine the provider when
`fips_enabled` is false. That way trying to manage a puppetserver gem
will print:
Error: /Stage[main]/Main/Package[uuid]: Provider puppetserver_gem is not functional on this host
instead of:
Error: Execution of '/opt/puppetlabs/bin/puppetserver gem install --no-document <gem>' returned 1:
ERROR: Loading command: install (NameError)
cannot load (ext) (org.jruby.ext.openssl.OpenSSL)
GabrielNagy
approved these changes
Sep 4, 2020
Magisus
approved these changes
Sep 4, 2020
|
We definitely don't expect this to be used on server right? Just loaded? |
|
Yeah, the server will be able to load the provider (via the Autoloader's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppetserver still loads all types and providers during catalog compilation,
and JRuby with FIPS enabled cannot require rubygems. So guard the require
statement like we do in puppet/ssl/openssl_loader.
The
/opt/puppetlabs/bin/puppetserver gem installcommand will failwhen running with JRuby with FIPS, so confine the provider when
fips_enabledis false. That way trying to manage a puppetserver gemwill print:
instead of: