Skip to content

Revert "Merge pull request #7401 from joshcooper/certmismatch_8213" #7416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

Revert "Merge pull request #7401 from joshcooper/certmismatch_8213" #7416

merged 1 commit into from
Mar 4, 2019

Conversation

joshcooper
Copy link
Contributor

This reverts commit aab7b62, reversing
changes made to 2c3f51b.

@joshcooper
Revert "Merge pull request puppetlabs#7401 from joshcooper/certmismat…
1d93086 
…ch_8213"

This reverts commit aab7b62, reversing
changes made to 2c3f51b.
@joshcooper joshcooper requested a review from a team March 4, 2019 18:01
@joshcooper
Copy link
Contributor Author

Commit aab7b62 incorrectly assumed the server's cert caused the SSLError to be raised, but it may not be, such as if the root or intermediate CA is unknown to the agent.

@jhelwig jhelwig merged commit 1a25a73 into puppetlabs:5.5.x Mar 4, 2019
@joshcooper joshcooper deleted the revert_certmismatch_8213 branch March 4, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhelwig jhelwig jhelwig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcooper @jhelwig