Skip to content

(maint) Add additional details on how to run spec tests #6964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2018
Merged

(maint) Add additional details on how to run spec tests #6964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@ the [puppet-dev mailing list](https://groups.google.com/forum/#!forum/puppet-dev
why this is a problem, and how the patch fixes the problem when applied.
```
* Make sure you have added the necessary tests for your changes.
* Run _all_ the tests to assure nothing else was accidentally broken. First
install all the test dependencies with `bundle install --path .bundle`. Then
either run all the tests serially with `bundle exec rspec spec` or in parallel
with `bundle exec rake parallel:spec[process_count]`
* For details on how to run tests, please see [the quickstart guide](https://github.com/puppetlabs/puppet/blob/master/docs/quickstart.md)

## Writing Translatable Code

Expand Down
2 changes: 2 additions & 0 deletions docs/quickstart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,5 @@ be used to send logs to a file, and to adjust the log level:
* `PUPPET_TEST_LOG_LEVEL`: change the log level to adjust how much detail
is captured. It defaults to `notice`; useful values include `info` and
`debug`.

For details on running tests on windows, see [the windows docs](https://github.com/puppetlabs/puppet/blob/master/docs/windows.md).
6 changes: 3 additions & 3 deletions docs/windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

If you'd like to run Puppet from source on Windows platforms, follow the [Quickstart](./quickstart.md) to using bundler and installing the necessary gems on Windows.

You will need to install Ruby on Windows from [rubyinstaller.org](http://rubyinstaller.org).
You will need to install Ruby on Windows from [rubyinstaller.org](http://rubyinstaller.org)
or from [Choclately](https://chocolatey.org/packages/ruby).

C:\> cd C:\work\puppet
C:\work\puppet> gem install bundler
C:\work\puppet> bundle install --path .bundle
C:\work\puppet> bundle install --path .bundle --without development extra
C:\work\puppet> bundle exec puppet --version
4.7.1

Expand Down Expand Up @@ -68,4 +69,3 @@ Then run the test as:
* Don't assume 'C' drive. Use environment variables to look these up:

"#{ENV['windir']}/system32/netsh.exe"