(CAT-1404)- Fix rubocop nightly failures #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
gavindidrichsen
force-pushed
the
cat-1404-fix_rubocop_nightly_failures
branch
from
b3e5afc
to
674e8f5
Compare
Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
david22swan
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR gets CI going green again by temporarily disabling the rubocop
Naming/MethodNameviolations occurring in 2 files:lib/puppet-strings/yard/handlers/ruby/data_type_handler.rblib/puppet-strings/yard/parsers/puppet/parser.rbSee issue #365 for more information and a placeholder for fixing the violations at a later stage. NOTE, #365 was created since
rubocop --auto-gen-configdoes not add the above violations to the.rubocop_todo.yml.