(CONT-1193) - Add --providers and --list-providers flags
#357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a fix that now allows the describe providers command to work. It also adds a null check before executing `each` on the describe_types variable as before this would result in unknown function each for Nil:Nil Class.
This commit completes the unfinished work to add logic for the --provider and --list-provider flags
jordanbreen28
force-pushed
the
CONT-1193-finish_providers_implementation
branch
from
6f3e8d3 to
3e1b641
Compare
|
Fantastic stuff! Thanks @jordanbreen28 🙏 |
chelnak
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR finishes the implementation of the
providersflag as this was never completed.It also adds a new flag that can be used to list all available providers and their respective types within the module.
Additional Context
adding
--providersto a describe command i.e.describe firewall --providers, returns the providers for the firewall type.running
--list-providerslists all providers in the module.Checklist