Skip to content

close method of transports not called #257

Open
@DavidS

Description

@DavidS

Describe the Bug

The close method on a Transport is not called at the end of processing.

Expected Behavior

The close method on a Transport should be called to release a transport's external resources at the end of processing.

Steps to Reproduce

By a community member on slack:

As a test, i added

def close(context)
    context.debug('Logout connection')

However, it doesn't get called. I don't see it in the logs

Additional Context

Any ruby-side resources are usually cleaned up at the end of processing by puppet device or ACE's forked processing. This does not help for resources that a transport allocates outside of ruby (e.g. opening a session on the target API).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions