Create a new plugin for ensuring a single space before a '=>'

[gerases]

This will trigger a warning only for resources with single parameters such as:

file { 'foo':
  ensure⎵⎵=> file,
}

Summary

Create a new plugin for ensuring a single space before a '=>' in resources with a single parameter. Arrow alignment for resources with multiple parameters (including detecting extra white space before the arrow) is already done in the arrow_alignment plugin.

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified.

[CLAassistant]

All committers have signed the CLA.

[bastelfreak]

Hi, are you aware of https://rubygems.org/gems/puppet-lint-strict_indent-check ? It also checks the alignment

[gerases]

Hi, are you aware of https://rubygems.org/gems/puppet-lint-strict_indent-check ? It also checks the alignment

Yes, I do have that installed but it wasn't catching this situation.

[jordanbreen28]

@gerases apologies for the such late response.. I've left a couple of comments above. Could you address those and we can try get this moving?
We also need you to sign the CLA.
Thanks for your work on this :)

[gerases]

@gerases apologies for the such late response..

@jordanbreen28 , ah, good point -- just changed and pushed -- is that better?

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (05af720) 93.15% compared to head (82ecfc7) 93.19%.

Files	Patch %	Lines
...int/plugins/check_whitespace/space_before_arrow.rb	95.83%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   93.15%   93.19%   +0.03%     
==========================================
  Files          54       55       +1     
  Lines        1768     1792      +24     
==========================================
+ Hits         1647     1670      +23     
- Misses        121      122       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bastelfreak]

the ) looks a bit odd.

[gerases]

good catch, fixed

[jordanbreen28]

@gerases could you sign the CLA? I've tested this locally and all works like a charm :)

[gerases]

@gerases could you sign the SLA? I've tested this locally and all works like a charm :)

I think I did but it's still saying pending?

[jordanbreen28]

@gerases ah! its been known to do this.

[jordanbreen28]

re-opening

[jordanbreen28]

Looks like this is the issue cla-assistant/cla-assistant#562 (comment)
You need to set your email via git config and then commit

[gerases]

Looks like this is the issue cla-assistant/cla-assistant#562 (comment) You need to set your email via git config and then commit

okeedok, working on this right now

[gerases]

Hmm, i can't seem to do anything here, should close the PR and create a new one?

[jordanbreen28]

Hmm, i can't seem to do anything here, should close the PR and create a new one?

@gerases It looks like you're commits are authored by a different email/user than your PR was created with (which is probably what you used to sign the CLA) 😃

[gerases]

Yeah, needed to rewrite the commits, should be good now

[gerases]

@bastelfreak, can you approve

[jordanbreen28]

Thanks for your contribution @gerases 😁

[gerases]

@jordanbreen28 , happy to contribute! Thank you all as well!