-
Notifications
You must be signed in to change notification settings - Fork 18
Do not crash when referring to a fact key without quoting it #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@chutzimir This is awesome. Thank you for taking the time to submit this patch. Please could you add a spec test to demonstrate the case & then I will merge. |
6d45386
to
43fc623
Compare
@chelnak I missed your message, but added the spec just now, also rebased on main. |
467f6a9
to
7a4e1cc
Compare
@chutzimir Thanks! Looks like you have some rubocop errors to fix before we can merge. Please could you take a look? |
@chelnak I think I addressed all of them. Should I squash those commits or is it OK as it is? |
Yes- could be great if you could clean up those commits a bit. Thanks! |
d070ee7
to
e481589
Compare
Done. It is three commits now, with each of them meaningful and independent, bringing its own value. |
Oh no the rubocop errors have reappeared! |
e481589
to
9deeffa
Compare
Wack! I now learned how to run rubocop locally before pushing. It was clean for me, let's see if the official pipeline agrees. |
Fixes #118