Onceover fixes #157
Merged
Onceover fixes #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albatrossflavour
commented
Jun 6, 2025
albatrossflavour
commented
- Added the PowerShell binary to allow onceover tests on windows nodes to work.
- Update the hiera eyaml gem to fix onceover runs
- Pin the big decimal gem to fix onceover parallel runs
- Include the rexml gem to fix onceover windows testing in general
… parallel spec runs
Magisus
reviewed
Jun 6, 2025
Gemfile
Outdated
| @@ -25,3 +25,5 @@ gem 'rspec-puppet', '~> 5.0' | |||
| gem 'rubocop', '~> 1.75' | |||
| gem 'unf_ext', '~> 0.0.9' | |||
| gem 'yamllint', '~> 0.0.9' | |||
| gem 'rexml' | |||
There was a problem hiding this comment.
Might be a good idea to at least pin the major version here, like we've done with the others: ~> 3.2
| @@ -25,3 +25,5 @@ gem 'rspec-puppet', '~> 5.0' | |||
| gem 'rubocop', '~> 1.75' | |||
| gem 'unf_ext', '~> 0.0.9' | |||
| gem 'yamllint', '~> 0.0.9' | |||
| gem 'rexml' | |||
| gem 'bigdecimal', '= 3.2.1' | |||
There was a problem hiding this comment.
Can you add a comment here about why this is pinned so precisely, so we can see it and know what to check to repro the issue if we want to see if things have been fixed upstream down the line?
There was a problem hiding this comment.
Sorry, missed this.
The various gem dependencies aren't currently met unless we add this specific gem at this version. We can revisit it as part of an overarching review of the structure.
If we don't include it, onceover (especially with --parallel) fails hard.
Magisus
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.