(maint) update to ember 5.12, modernize components and tests #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does the base update to ember 5.12
The two-way binding `Input` component is deprecated in favor of action handlers. This updates the dummy app to remove the use of the `Input` component.
This removes the linter warning about the use of curly braces around simple strings.
jonathannewman
force-pushed
the
maint/main/update-ember-512
branch
from
d8acf3c to
c190476
Compare
This removes the use of ember run loop functions in favor of ember-lifeline. It also uses modifiers instead of constructor functions for the components to register with parents. It updates the tests to use simple instead of index as the route as the different pages had coincidental handlers and it was causing issues. Tests were also modernized.
jonathannewman
force-pushed
the
maint/main/update-ember-512
branch
from
c190476 to
de0b1ae
Compare
|
@Lukeaber This should make it possible to upgrade to 6.x |
Lukeaber
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit comments.