Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolvers/networking.rb: avoid calling ipconfig unless Windows #2481

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

resolvers/networking.rb: avoid calling ipconfig unless Windows #2481

wants to merge 2 commits into from

Commits on Apr 21, 2022

  1. resolvers/networking.rb: avoid calling ipconfig unless Windows 

    The following message was observed when running 'puppet catalog compile'
under RUBYOPT="--debug" with Puppet 7 and Facter 4.2.9 on FreeBSD 12.3

~~~~
Exception `Errno::ENOENT' at /opt/puppet/puppet_wk/puppet_ctl/tools/bundle/ruby/3.0/gems/facter-4.2.9/lib/facter/custom_facts/core/execution/popen3.rb:17 - No such file or directory - ipconfig
~~~~

In order to prevent the call to the Microsoft Windows ipconfig tool,
this changeset adds an additional test under the method
 Facter::Resolvers::Networking.extract_dhcp

The patched networking.rb has been tested with Puppet 7 from a local
installation under Ruby 3.0 from FreeBSD ports, on FreeBSD 12.3

(cherry picked from commit 614213a)
    @spchamp
    spchamp committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    2f61dca View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. extract_dhcp: Updating previous :windows test => :macosx 

    Updating the previous change for Facter::Resolvers::Networking.extract_dhcp
to check for :macosx instead of :windows before calling the platform's
ipconfig cmd
    @spchamp
    spchamp committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    5ef4973 View commit details
    Browse the repository at this point in the history