Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-2829) Fixed partitions and mount points facts #2146

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

Filipovici-Andrei
Copy link
Contributor

Problem:
On ubuntu 20.04, amazon vm, the partitions paths were detected as '/dev/sys/block/'
instead of '/dev/'.
The root partition was detected by it's PARTUUID instead of it's path.
Fix:
'sys/block' is not added to the partitions path if it's data is extracted from '/sys/block//dm', or
'/sys/block//loop' folders.
If /proc/cmdline returns the root partition's PARTUUID then, if possible, we make an extra call to blkid to get it's path.

@Filipovici-Andrei Filipovici-Andrei added do not merge bug Something isn't working labels Oct 16, 2020
@Filipovici-Andrei Filipovici-Andrei requested review from a team October 16, 2020 15:19
@puppetcla
Copy link

CLA signed by all contributors.

@Filipovici-Andrei
Copy link
Contributor Author

jenkins please test this on all

@oanatmaria oanatmaria merged commit 8d6d51a into puppetlabs:main Oct 21, 2020
@Filipovici-Andrei Filipovici-Andrei deleted the FACT-2829 branch October 21, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants