(maint) Add nil check for ec2 facts. #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanatmaria
approved these changes
Aug 24, 2020
gimmyxd
reviewed
Aug 24, 2020
| def aws? | ||
| private | ||
|
|
||
| def aws_hypervisors? |
There was a problem hiding this comment.
Is this the correct way to fix it? as this will return true for non-aws machines, so even if we are not an AWS we'll continue to resolve the fact knowing we're not on the right path.
Was facter 3 using dmidecode for this check?
There was a problem hiding this comment.
Unfortunately there isn't a clean way to find out if it's aws. We can only check if the vm is on one of aws's hypervisors. Facter 3 does the same thing :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.