Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-2742) Exclude net/https when running on jruby FIPS #2030

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

BogdanIrimie
Copy link
Contributor

@BogdanIrimie BogdanIrimie commented Aug 13, 2020

net/http uses openssl which is not FIPS compliant on jRuby. We can use the same mechanism that is used for missing gems to detect this case and log an error message, but continue to provide the facts we can resolve.

@BogdanIrimie BogdanIrimie marked this pull request as ready for review August 13, 2020 14:56
@BogdanIrimie BogdanIrimie requested review from a team August 13, 2020 14:56
@BogdanIrimie BogdanIrimie added bug Something isn't working and removed do not merge labels Aug 13, 2020
Copy link

@Magisus Magisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect, thanks!

@Filipovici-Andrei Filipovici-Andrei merged commit 2dc7bab into puppetlabs:4.x Aug 14, 2020
@puppetcla
Copy link

CLA signed by all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants