(FACT-2734) Return nil codename if we cannot determine it from /etc/redhat_release #2003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation assumed that
/etc/redhat-release
always containscodename
, but there might be cases when it does not. When this happened, and we were running on an os that did not have/etc/os-release
Facter, would try/etc/redhat-release
and would fail to start.The
fix
returns nil when there is no codename in/etc/redhat-relase
. This allows Facter to start even when there is nocodename
.