Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-2717) Block external facts #1998

Merged
merged 1 commit into from
Jul 30, 2020
Merged

(FACT-2717) Block external facts #1998

merged 1 commit into from
Jul 30, 2020

Conversation

florindragos
Copy link
Contributor

No description provided.

@florindragos florindragos requested review from a team July 28, 2020 12:01
@florindragos florindragos added do not merge enhancement New feature or enhancement labels Jul 28, 2020
@florindragos florindragos force-pushed the FACT-2717 branch 3 times, most recently from c4ba724 to 272216e Compare July 28, 2020 13:34
@puppetcla
Copy link

CLA signed by all contributors.

@florindragos florindragos force-pushed the FACT-2717 branch 2 times, most recently from fe8b5a5 to 9aee27f Compare July 29, 2020 10:51
extend Facter::Acceptance::UserFactUtils

agents.each do |agent|
os_version = on(agent, facter('kernelmajversion')).stdout.chomp.to_f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os_version does not seam to be used

@BogdanIrimie BogdanIrimie merged commit a52856b into 4.x Jul 30, 2020
@mihaibuzgau mihaibuzgau deleted the FACT-2717 branch August 19, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants