(maint) handle Time and Symbol in executable facts #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executable facts can produce structured facts if they produce a YAML output, when parsing the output script, YAML.safe_load does not know to handle Time and Symbol. This commit allow YAML to load Time and Symbol from output.
Remove `rescue Exception` from parser since this is just responsible of formating the output. The extra handling should be done in Facter::Core::Execution, if needed.
gimmyxd
force-pushed
the
maint/fix_yaml_load
branch
from
5fc2f9c
to
e1835ff
Compare
|
Jenkins please test this on all |
|
CLA signed by all contributors. |
|
Jenkins please test this on all |
oanatmaria
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executable facts can produce structured facts if they
produce a YAML output, when parsing the output script,
YAML.safe_load does not know to handle Time and Symbol.
This commit allow YAML to load Time and Symbol from output.