Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

(FACT-2635) Incorrect output for non existing fact #536

Merged
merged 15 commits into from
Jun 3, 2020
Merged

(FACT-2635) Incorrect output for non existing fact #536

merged 15 commits into from
Jun 3, 2020

Conversation

BogdanIrimie
Copy link
Contributor

@BogdanIrimie BogdanIrimie commented May 26, 2020 •
edited
Loading

When querying  for two facts, one that exists and one that does not, Facter 4 outputs only the fact that exists. It should output both facts, the one that does not exist with nil (or empty depending on the formatter) value

e.g. no fix

facter os.name test

Darwin

e.g. with fix

facter os.name test

os.name => Darwin
test =>

@BogdanIrimie BogdanIrimie added the bugfix Something isn't working label May 26, 2020
@BogdanIrimie BogdanIrimie marked this pull request as ready for review May 28, 2020 14:35
@BogdanIrimie BogdanIrimie requested review from a team May 28, 2020 14:35
@oanatmaria oanatmaria merged commit 9ccba54 into master Jun 3, 2020
@oanatmaria oanatmaria deleted the FACT-2635 branch June 3, 2020 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oanatmaria oanatmaria oanatmaria approved these changes

@gimmyxd gimmyxd Awaiting requested review from gimmyxd

Assignees
No one assigned
Labels
bugfix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BogdanIrimie @gimmyxd @oanatmaria