This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2559) Fix Facter.debugging? call when Facter not fully loaded #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimmyxd
reviewed
Apr 16, 2020
Added tests for when Facter is not fully loaded
Filipovici-Andrei
force-pushed
the
FACT-2559
branch
from
11f6b70
to
35015af
Compare
Filipovici-Andrei
force-pushed
the
FACT-2559
branch
from
dea109a
to
bbfe315
Compare
sebastian-miclea
previously approved these changes
Apr 22, 2020
Added in logger_spec.rb removal of multi_logger_double
BogdanIrimie
approved these changes
Apr 24, 2020
Filipovici-Andrei
added a commit
that referenced
this pull request
Apr 28, 2020
…455) * (FACT-2559) added check if Facter.debugging? is loaded * (FACT-2559) Fixed some tests leakage in logger_spec.rb Added tests for when Facter is not fully loaded * (FACT-2559) Created a context for when debugging is set to false * (FACT-2559) refactored debugging_active? * (FACT-2559) refactored file_helper.rb and file_helper_spec.rb Added in logger_spec.rb removal of multi_logger_double Co-authored-by: Andrei Filipovici <andrei.filipovici@andreis-mbp.eth.tsr.corp.puppet.net> Co-authored-by: Bogdan Irimie <bogdan.irimie@puppet.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.