This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2530) Fix for tests/facts/os_processors_and_kernel.rb #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/resolvers/os_release_resolver.rb
Outdated
| @@ -36,6 +36,7 @@ def read_os_release_file(fact_name) | |||
|
|
|||
| fill_fact_list(pairs) | |||
| process_name | |||
| alter_version_id | |||
There was a problem hiding this comment.
I would rename this to pad_version_id. Alter is very generic.
BogdanIrimie
approved these changes
Apr 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem: On Ubuntu os.release should be {full: 18.04, major: 18.04} instead of {full: 18.04, major: 18, minor: 4}(as. it is currently). On Sles release should be padded with 0: 15.0 instead of 15. On Aix and Solaris processors fact is missing.
Fix description: Fixed release on ubuntu and sles. Aix and Solaris facts will be added with a different PR.