This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2498) Internal fact loader should only load facts once #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 30, 2020 12:53
…ip them if they are already loaded. LoadedFacts that are created from aliases or from wilecard facts will have type :legacy.
gimmyxd
reviewed
Mar 30, 2020
gimmyxd
previously approved these changes
Mar 31, 2020
gimmyxd
reviewed
Mar 31, 2020
gimmyxd
previously approved these changes
Mar 31, 2020
Filipovici-Andrei
previously approved these changes
Mar 31, 2020
BogdanIrimie
dismissed stale reviews from Filipovici-Andrei and gimmyxd
via
5c54d93
Filipovici-Andrei
previously approved these changes
Mar 31, 2020
Filipovici-Andrei
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having an OS hierarchy, we should start loading facts from the bottom of the hierarchy and only load facts one. The PR fixes fact_type for LoadedFacts as well.