Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize IMU pitch/roll values to [-180, 180] #2171

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Normalize IMU pitch/roll values to [-180, 180] #2171

merged 2 commits into from
Jul 28, 2021

Conversation

N-M-T
Copy link
Contributor

@N-M-T N-M-T commented Jul 28, 2021

No description provided.

@N-M-T N-M-T requested a review from papr July 28, 2021 07:51
papr
papr suggested changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@papr papr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-M-T Thank you for the PR! Please see the nitpicking suggestions. :)

pupil_src/shared_modules/imu_timeline.py Outdated
Comment on lines 214 to 215
roll = ((roll + 180) % 360) - 180
self.roll = roll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
roll = ((roll + 180) % 360) - 180
self.roll = roll
self.roll = ((roll + 180) % 360) - 180

pupil_src/shared_modules/imu_timeline.py Outdated
Comment on lines 230 to 231
pitch = ((pitch + 180) % 360) - 180
self.pitch = pitch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pitch = ((pitch + 180) % 360) - 180
self.pitch = pitch
self.pitch = ((pitch + 180) % 360) - 180

@papr papr changed the base branch from master to develop July 28, 2021 09:19
@papr papr merged commit 76bc704 into pupil-labs:develop Jul 28, 2021
@N-M-T N-M-T deleted the imu_timeline branch July 29, 2021 12:10
@N-M-T N-M-T restored the imu_timeline branch July 29, 2021 18:26
@N-M-T N-M-T deleted the imu_timeline branch July 29, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papr papr papr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N-M-T @papr