Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording-specific hotkeys #2170

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Recording-specific hotkeys #2170

merged 2 commits into from
Aug 18, 2021

Conversation

papr
Copy link
Contributor

@papr papr commented Jul 27, 2021

Starting with this PR, annotation definitions are stored in <recording dir>/offline_data/annotation_definitions.json with the format

{
    "version": 1,
    "definitions": {
        "<label>": "<hotkey>"
    }
}

This file can be shared between recordings.

On load, Pupil Player attempts to load the annotation definitions from the recording-specific file. If it is not found or invalid, it will fallback to the session settings, i.e. the last known annotation definitions.

@papr papr marked this pull request as ready for review July 29, 2021 15:00
@papr papr requested review from romanroibu and N-M-T July 29, 2021 15:00
Copy link
Contributor

@N-M-T N-M-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works a treat, the functionality is just what I would expect.
One condition where a user could lose their annotations hotkeys is if Player is closed via the terminal or crashes prior to a normal shutdown or new file load. I'm not sure that is such an issue

@papr papr merged commit c6cd403 into develop Aug 18, 2021
@papr papr deleted the recording-specific-hotkeys branch August 18, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants