Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Player crashing with OSError: [Errno -9986] Internal PortAudio error #2103

Merged
merged 3 commits into from
Mar 3, 2021
Merged

Workaround for Player crashing with OSError: [Errno -9986] Internal PortAudio error #2103

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
579632e
Handle OSError expections raised by PortAudio
romanroibu Feb 25, 2021
a818094
Guard audio_timeline from being None before calling refresh
romanroibu Feb 25, 2021
4f4b87d
Handle OSError in Audio_Playback._setup_output_audio separately
romanroibu Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pupil_src/shared_modules/audio_playback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,12 @@ def _setup_output_audio(self):

except ValueError:
self.pa_stream = None
except OSError:
self.pa_stream = None
import traceback

logger.warning("Audio found, but playback failed (#2103)")
logger.debug(traceback.format_exc())

def _setup_audio_vis(self):
self.audio_timeline = None
Expand Down Expand Up @@ -321,7 +327,7 @@ def update_audio_viz(self):
self.audio_viz_data, finished = self.audio_viz_trans.get_data(
log_scale=self.log_scale
)
if not finished:
if not finished and self.audio_timeline:
self.audio_timeline.refresh()

def setup_pyaudio_output_if_necessary(self):
Expand Down