Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective glfw error reporting #2086

Merged
merged 5 commits into from
Jan 19, 2021
Merged

Selective glfw error reporting #2086

merged 5 commits into from
Jan 19, 2021

Conversation

romanroibu
Copy link
Contributor

No description provided.

@papr
Copy link
Contributor

papr commented Jan 14, 2021

Waiting for a customer to confirm the correct functionality.

@papr
Copy link
Contributor

papr commented Jan 15, 2021

@romanroibu Looks like we need to allow the error during init(), not during create_window()`.

$ cd pupil/pupil_src
$ git branch
* glfw-selective-error-reporting
$ python3 main.py capture
MainProcess - [INFO] os_utils: Disabled idle sleep.
world - [INFO] launchables.world: Application Version: 3.0.24
world - [INFO] launchables.world: System Info: <redacted>
world - [INFO] launchables.world: Session setting are from a different version of this app. I will not use those.
world - [ERROR] launchables.world: Process Capture crashed with trace:
Traceback (most recent call last):
  File "/Users/<redacted>/pupil/pupil_src/launchables/world.py", line 529, in world
    glfw.init()
  File "/usr/local/lib/python3.9/site-packages/glfw/__init__.py", line 730, in init
    res = _glfw.glfwInit()
  File "/usr/local/lib/python3.9/site-packages/glfw/__init__.py", line 632, in errcheck
    _reraise(exc[1], exc[2])
  File "/usr/local/lib/python3.9/site-packages/glfw/__init__.py", line 54, in _reraise
    raise exception.with_traceback(traceback)
  File "/usr/local/lib/python3.9/site-packages/glfw/__init__.py", line 611, in callback_wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/glfw/__init__.py", line 832, in _handle_glfw_errors
    raise GLFWError(message, error_code=error_code)
glfw.GLFWError: (65544) b'Cocoa: Failed to find service port for display'

world - [INFO] launchables.world: Process shutting down.
MainProcess - [INFO] os_utils: Re-enabled idle sleep.

@papr papr merged commit 341c376 into develop Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants