Detect feature branches written with a different format #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently detect
feature/XXX
branches, which we use to make npm tags likefeature-xxx
. This works well except for one significant problem.Specifically, because of golang/go#30851 we are unable to reference these feature branches using go modules. This is problematic as there's no easy way to then have downstream repos (like
@pulumi/aws
) reference the latest built version from this branch. While we can reference teh package by commit, that's much more error prone and difficult to manage.This PR simply allows us to actually write our branches like
feature-xxx
instead of justfeatures/xxx
. This is actually simpler as we simply use that branch name as is instead of having to convert it to this form (like we do withfeatures/xxx
=>feature-xxx
).With this, downstream branches can then do
go get github.com/pulumi/pulumi@feature-2.0
and have it work properly.