Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect feature branches written with a different format #94

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

CyrusNajmabadi
Copy link
Contributor

We currently detect feature/XXX branches, which we use to make npm tags like feature-xxx. This works well except for one significant problem.

Specifically, because of golang/go#30851 we are unable to reference these feature branches using go modules. This is problematic as there's no easy way to then have downstream repos (like @pulumi/aws) reference the latest built version from this branch. While we can reference teh package by commit, that's much more error prone and difficult to manage.

This PR simply allows us to actually write our branches like feature-xxx instead of just features/xxx. This is actually simpler as we simply use that branch name as is instead of having to convert it to this form (like we do with features/xxx=>feature-xxx).

With this, downstream branches can then do go get github.com/pulumi/pulumi@feature-2.0 and have it work properly.

@CyrusNajmabadi
Copy link
Contributor Author

Going to move ahead with this to unblock my testing efforts.

@CyrusNajmabadi CyrusNajmabadi merged commit c6320eb into master Jan 30, 2020
@pulumi-bot pulumi-bot deleted the featureBranches branch January 30, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant