Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xargs for publishing nuget packages #134

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jaxxstorm
Copy link
Contributor

Currently we use find for publishing nuget packages. find will only exit with a non 0 error code if you fail to traverse a directory.

This can lead to a situation whereby the nuget package fails to publish, but we never know about it:

find sdk/dotnet/bin/Debug -name 'Pulumi.*.nupkg' | xargs dotnet nuget push -k foobar -s https://api.nuget.org/v3/index.json
echo $?
0

With the addition of the fact that nuget keys expire, we probably need to be notified when nuget publishing fails.

This switches us to use xargs instead

@t0yv0 t0yv0 self-requested a review January 6, 2022 15:12
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants