Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate custom Key Vault resource to azidentity #3664

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thomas11
Copy link
Contributor

  • Use KV in the azure-in-azure test to test different auth scopes
  • Migrate custom KV resource to azidentity. Need to preserve the previous one due to special authorizer.
  • Fall back to previous custom KV resources to use correct authorizer

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 25.80645% with 46 lines in your changes missing coverage. Please review.

Project coverage is 59.91%. Comparing base (8a11520) to head (b45a6a7).

Files with missing lines Patch % Lines
...ources/customresources/custom_keyvault_autorest.go 17.14% 27 Missing and 2 partials ⚠️
...r/pkg/resources/customresources/custom_keyvault.go 0.00% 13 Missing ⚠️
...r/pkg/resources/customresources/customresources.go 71.42% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3664      +/-   ##
==========================================
- Coverage   60.15%   59.91%   -0.25%     
==========================================
  Files          68       69       +1     
  Lines       10878    10928      +50     
==========================================
+ Hits         6544     6547       +3     
- Misses       3831     3877      +46     
- Partials      503      504       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant