Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gotestfmt as it's unreliable #3596

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Remove gotestfmt as it's unreliable #3596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/actions/test-setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,3 @@ runs:
- name: Install dependencies
run: make install_${{ inputs.language}}_sdk
shell: bash

- name: Install gotestfmt
uses: jaxxstorm/action-install-gh-release@v1.11.0
with:
tag: v2.5.0
repo: GoTestTools/gotestfmt
14 changes: 4 additions & 10 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,13 @@ jobs:
ARM_CLIENT_CERTIFICATE_PATH_FOR_TEST: "${{ runner.temp }}/azure-client-certificate.pfx"
run: |
set -euo pipefail
cd examples && go test -v -json -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log | gotestfmt
cd examples && go test -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log
- name: Run short tests
if: inputs.short_test
run: |
set -euo pipefail
cd examples && go test -v -json -cover -timeout 15m -short -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log | gotestfmt
cd examples && go test -cover -timeout 15m -short -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log
test_examples:
needs: build_sdks
Expand Down Expand Up @@ -263,7 +263,7 @@ jobs:
cd examples && \
go mod edit -replace github.com/pulumi/examples/misc/test=../p-examples/misc/test/ && \
go mod tidy && \
go test -v -json -cover -timeout 2h -tags=${{ matrix.language }} -run TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log | gotestfmt
go test -cover -timeout 2h -tags=${{ matrix.language }} -run TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log
test_provider:
runs-on: ubuntu-latest
Expand All @@ -281,12 +281,6 @@ jobs:
with:
skip_dotnet_and_java: "true"

- name: Install gotestfmt
uses: jaxxstorm/action-install-gh-release@v1.11.0
with:
tag: v2.5.0
repo: GoTestTools/gotestfmt

- run: make ensure

- name: Prerequisites artifact restore
Expand All @@ -302,7 +296,7 @@ jobs:
- name: Test Provider Library
run: |
set -euo pipefail
cd provider && go test -v -json -coverprofile="coverage.txt" -coverpkg=./... -timeout 1h -parallel 16 ./... 2>&1 | tee /tmp/gotest.log | gotestfmt
cd provider && go test -coverprofile="coverage.txt" -coverpkg=./... -timeout 1h -parallel 16 ./... 2>&1 | tee /tmp/gotest.log
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v4
Expand Down
Loading