-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for AWS Service Connections #149
base: master
Are you sure you want to change the base?
Add Support for AWS Service Connections #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
In the future, you can just clone this repo directly and create a branch for the PR, rather than from your fork.
I was following the Contributing doc but noted for next time! Thanks! Also, I noticed we do some integration testing, we will need to create an AWS service connection in the ADO org we run the test in if we want to add additional integration tests to cover this feature. |
Co-authored-by: Justin Van Patten <jvp@justinvp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also, I noticed we do some integration testing, we will need to create an AWS service connection in the ADO org we run the test in if we want to add additional integration tests to cover this feature
Yeah, it would be good to have a test, if it's easy to setup. Can you do that?
Co-authored-by: Justin Van Patten <jvp@justinvp.com>
@justinvp I added the new awsServiceConnection input to the integration azure pipeline file on 137ddd7. Someone will need to add an aws service connection to the test organization in Azure Devops for the integration test to reference. I do not have access to that. The service connection is provided via the The AWS Toolkit for Azure Devops. |
Thank you for contributing! Before submitting your PR, can you please confirm that you have done the following?
name
,publisher
, andgalleryFlags
in thevss-extension.json
file, you have reverted them.id
,name
,author
, you have reverted them.vss-extension.json
andtask.json
, OR I didn't change them.Related to: #80