Improves the dynamic providers docs page examples to reflect how to pass creds via env variables and configuration. #13372
+324
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pulumi/pulumi#17673 and pulumi/pulumi#17697 we introduced a new optional configure method that has access to the stack configuration. Wait for the next Pulumi release before merging this
Co-authored-by: Will Jones <will@sacharissa.co.uk>
MitchellGerdisch
temporarily deployed
to
testing
GitHub Actions
Inactive
|
Your site preview for commit e83d864 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13372-e83d8649.s3-website.us-west-2.amazonaws.com. |
MitchellGerdisch
temporarily deployed
to
testing
GitHub Actions
Inactive
MitchellGerdisch
temporarily deployed
to
testing
GitHub Actions
Inactive
|
Your site preview for commit 49f0cda is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13372-49f0cdaa.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit b71e675 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13372-b71e6758.s3-website.us-west-2.amazonaws.com. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The dynamic providers page has examples that do not show best practices for passing in secrets. This update modifies the github example to use the (new)
configure()interface.It also removes the simple
configure()example that was added with the docs update to add the interface.Unreleased product version (optional)
Related issues (optional)