-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change refresh
behavior to use --refresh
flag
#1118
base: main
Are you sure you want to change the base?
Conversation
@fitz-vivodyne Thanks for the PR and sorry about the delay here. I've just let the tests run, and there are some failures. I believe this has the same cause as #1116 (review), and I think the option needs to be added to the |
Thanks @tgummerer, just pushed the updates to |
Hello 👋 Thanks for doing this, @fitz-vivodyne! I am wondering what you think of keep using the For most users they expect to be using this way of refreshing. We need to bump major, since it might break things, but it's the same kind of breaking we've done since v2; smaller and easy to migrate. |
@simenandre I found the current behavior surprising and when I first started using the action I 100% expected the Agreed that a major version bump would be appropriate, and I'm personally supportive of fully replacing the Thoughts on moving forward? |
I think a new major release and changing the refresh functionality would make sense here as well. I think updating this PR sounds good, but no strong preferences here either way. |
+1 to changing the refresh functionality and bumping the major version. I'm guessing the reason it behaved this way originally was because automation api didn't have support for the refresh flag.
EDIT: Looks like we at least have the refresh option for up and preview in nodejs automation api, but would be great to get this supported for |
@tgummerer I think we should provide the guidance for what we want to happen here. Let's make the decision and try to land this PR, or decide not to land it and describe the alternative. |
I'd be happy to land this PR if @fitz-vivodyne wants to update it with the updated |
@fitz-vivodyne Will you have time to take another step on this PR? |
Sorry, haven't had bandwidth recently. |
@fitz-vivodyne Do you mind converting it to a Draft PR for now, so that it doesn't show up in our review queue? |
Alright, I find myself wanting this functionality again so I just pushed the discussed changes to the PR. This now represents a breaking change/major release that would change the behavior of |
soft-refresh
config option to enable preview --refresh
/up --refresh
refresh
behavior to use --refresh
flag
As described in #870, the current
refresh
config option runspulumi refresh
prior to the requested command, updating the state file. There is not currently a way to runpulumi preview --refresh
orpulumi up --refresh
.This PR adds asoft-refresh
flag which enables the--refresh
flag.Not sure on the right approach for naming, but I figured this helps get across the difference betweenrefresh
updatingthe state and--refresh
not updating the state.After further discussion, this PR represents a breaking change.
As of this PR when
refresh = true
the existingpulumi refresh && pulumi <command>
behavior is removed and commands are instead run with--refresh
Completely untested at this point.
I took a look at existing tests and didn't see an obvious place to add a test.
No local testing yet either, will play with that in a bit, erring on the side of opening early to enable discussion.