Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fallback date for nextRunAt #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fermentfan
Copy link

This just creates wrong data. Old jobs that have been executed already and will not be executed again appear as jobs that will run at the current date (as their date is null). It should just be null instead like it is written in the persistence layer. No need for a fallback.

Is this behaviour important for some other logic?

This just creates wrong data. Old jobs that have been executed already and will not be executed again appear as jobs that will run at the current date (as their date is null). It should just be null instead like it is written in the persistence layer. No need for a fallback.
@code-xhyun code-xhyun added invalid This doesn't seem right and removed released labels Oct 11, 2024
@code-xhyun
Copy link
Contributor

@fermentfan As of now, deleting this value may cause side effects. Please post the specific case where deleting this is necessary in the issue, and I will take a look.

@fermentfan
Copy link
Author

fermentfan commented Oct 11, 2024

We simply query jobs like this:

await this.pulse.jobs({ type: 'normal' });

This returns a set of jobs, in which all jobs that originally have a null 'nextRunAt' in mongodb, have the fallback applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants