Add support for GCS Object Storage #1509
Conversation
|
Hi @balasankarc. Thanks for your PR. I'm waiting for a pulp member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
balasankarc
force-pushed
the
add-gcs-support
branch
2 times, most recently
from
ecbb7f5 to
0b64f85
Compare
balasankarc
changed the title
| ` | ||
| *pulpSettings += fmt.Sprintln("}") | ||
| } | ||
|
|
There was a problem hiding this comment.
The logic above is essentially copied from how we do S3 secrets below.
Expose bucket name to configure GCS as object storage backend for Pulp. Also expose optional fields like `iam_sign_blob`, `querystring_auth`, and `file_overwrite`. closes pulp#794 Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
balasankarc
force-pushed
the
add-gcs-support
branch
from
0b64f85 to
826ed67
Compare
|
@ipanova @git-hyagi This should be now ready for review. I didn't see any unit tests existing for Azure/S3, so I haven't done anything for GCS either. |
|
/ok-to-test |
git-hyagi
left a comment
git-hyagi
left a comment
There was a problem hiding this comment.
Hi @balasankarc
Thank you for your contribution!!
I didn't see any unit tests existing for Azure/S3, so I haven't done anything for GCS either.
Yeah, our unit tests are indeed lacking additional coverage and unfortunately we didn't have time to work on it yet.
The CI is failing in some steps, but I don't think they are related to this change (I will investigate and fix them later, in another PR).
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: balasankarc, git-hyagi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@git-hyagi Will it be possible to tag a new release with this change? Thanks. /cc @bmbouter |
|
Hi @balasankarc, Sorry for the delayed response! |
@git-hyagi Should https://github.com/pulp/pulp-operator/blob/1.1.0/Makefile#L6 say 1.1.0? 🤔 |
|
hmm ... I believe you are right. I probably messed up with the release versioning. |
2 participants
Expose bucket name and project ID to configure GCS as object storage backend for Pulp.
Ideally, we should support mounting a credentials file to the pods and/or setting
GOOGLE_APPLICATION_CREDENTIALSenv variable (to point to it). This PR does not do that, and only enables GCS support using the Application Default Credentials.closes #794