Skip to content

Error-prone code duplication in Snitch cluster VIP #229

@colluca

Description

@colluca

This line breaks if the internal boot ROM is not enabled.

localparam addr_t PeriphBaseAddr = CfgClusterBaseAddr + ((TcdmSize + BootromSize) * 1024);

In general, recalculating this address here is dangerous. It's likely to forget to update this, when changes are made in snitch_cluster.sv . We probably want these addresses to be calculated in a single place, e.g. in snitch_cluster_pkg.sv. Moving the calculation to a function could also be an option.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions