-
Notifications
You must be signed in to change notification settings - Fork 3
ci: Cache .cache/pip
instead of .venv
#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a2f642
to
fcafaac
Compare
fcafaac
to
4713e80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI caching strategy to cache only pip packages instead of the entire virtual environment and consolidates the init-deps and init-pd jobs into a single job.
- Updated the Makefile to use a new PIP_CACHE_DIR variable for pip package installation.
- Modified .gitlab/common.yml to cache only the pip packages and removed caching of the virtual environment.
- Updated .gitlab-ci.yml to replace references to the removed init-pd job with init-deps and added artifacts for pd/ci.yml.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
Makefile | Introduced PIP_CACHE_DIR and updated pip install commands to use caching. |
.gitlab/common.yml | Replaced caching of .venv with .cache/pip and centralized cache settings. |
.gitlab-ci.yml | Updated job dependencies and artifacts, replacing the init-pd reference. |
Comments suppressed due to low confidence (1)
.gitlab/common.yml:6
- [nitpick] Verify that the use of the YAML merge key (<<: *global_cache) is supported by the GitLab runner version in use and is clearly documented.
PIP_CACHE_DIR: "$CI_PROJECT_DIR/.cache/pip"
@@ -154,6 +154,7 @@ include $(PB_ROOT)/target/sim/traces.mk | |||
######## | |||
|
|||
BASE_PYTHON ?= python | |||
PIP_CACHE_DIR ?= $(PB_ROOT)/.cache/pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding a brief comment explaining the purpose of PIP_CACHE_DIR to improve clarity for future maintainers.
Copilot uses AI. Check for mistakes.
subpipe: | ||
stage: build | ||
needs: | ||
- init-pd | ||
- init-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that all downstream jobs and documentation reflect the change from init-pd to init-deps to avoid potential job dependency issues.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
init-deps
andinit-pd
CI jobs, which essentially did the same thing.